Skip to content

HBASE-26592 Fix the broken shaded protobuf module #70

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Apache9 merged 1 commit into from
Dec 17, 2021
Merged

HBASE-26592 Fix the broken shaded protobuf module #70

Apache9 merged 1 commit into from
Dec 17, 2021

Conversation

@Apache9
Copy link
Contributor

@Apache9 Apache9 commented Dec 17, 2021

No description provided.

@Apache9 Apache9 self-assigned this Dec 17, 2021
@Apache9
Copy link
Contributor Author

Apache9 commented Dec 17, 2021

Remove protobuf-java dependency, we only need to unpack its source so only need the artifact dependency in maven dependency plugin.

Add a resources section to include the proto files when generating the final jar.

@Apache-HBase
Copy link

Apache-HBase commented Dec 17, 2021

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 1m 11s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
-0 ⚠️ test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+1 💚 mvninstall 0m 46s master passed
+1 💚 compile 0m 9s master passed
+1 💚 javadoc 0m 8s master passed
_ Patch Compile Tests _
+1 💚 mvninstall 0m 10s the patch passed
+1 💚 compile 0m 9s the patch passed
+1 💚 javac 0m 9s the patch passed
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 xml 0m 1s The patch has no ill-formed XML file.
+1 💚 javadoc 0m 5s the patch passed
_ Other Tests _
+1 💚 unit 0m 9s hbase-shaded-protobuf in the patch passed.
+1 💚 asflicense 0m 6s The patch does not generate ASF License warnings.
3m 2s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-Thirdparty-PreCommit/job/PR-70/1/artifact/yetus-precommit-check/output/Dockerfile
GITHUB PR #70
Optional Tests dupname asflicense javac javadoc unit xml compile
uname Linux 0eff5a9cf227 5.4.0-1025-aws #25~18.04.1-Ubuntu SMP Fri Sep 11 12:03:04 UTC 2020 x86_64 GNU/Linux
Build tool maven
git revision master / c81cf5c
Default Java Oracle Corporation-1.8.0_282-b08
Test Results https://ci-hadoop.apache.org/job/HBase/job/HBase-Thirdparty-PreCommit/job/PR-70/1/testReport/
Max. process+thread count 39 (vs. ulimit of 1000)
modules C: hbase-shaded-protobuf U: hbase-shaded-protobuf
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-Thirdparty-PreCommit/job/PR-70/1/console
versions git=2.20.1
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache9 Apache9 merged commit 775a3bc into apache:master Dec 17, 2021
asfgit pushed a commit that referenced this pull request Dec 17, 2021
@Apache9
HBASE-26592 Fix the broken shaded protobuf module (#70)
0710f6b 
Signed-off-by: Pankaj Kumar <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pankaj72981 pankaj72981 pankaj72981 approved these changes

Assignees

@Apache9 Apache9

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Apache9 @Apache-HBase @pankaj72981